* Switch from setup.py to pyproject.toml #68
Conversation
mkopec87
commented
Dec 13, 2024
•
mkopec87
commented
- Switch from setup.py to pyproject.toml
- Add numpy<2,pandas<2 test environment to build pipeline test matrix
* Add numpy<2,pandas<2 test environment to build pipeline test matrix * Refactor build pipeline config file
mkopec87
force-pushed
the
feature/switch-to-toml
branch
from
3517e8d to
e65c729
Compare
| dynamic = ["version"] | ||
|
|
||
| [project.optional-dependencies] | ||
| test = [ |
There was a problem hiding this comment.
Can you add the optional dependencies:
`pandas = [
"pandas"
]
spark = [
"pyspark>=3.1; python_version <= '3.11'",
]
`
.github/workflows/test.yml
Outdated
| if [ "${{ matrix.numpy_version }}" = "numpy<2" ]; then | ||
| pip install ".[test,test_numpy_pre2]" | ||
| else | ||
| pip install ".[test]" |
There was a problem hiding this comment.
Can you switch [test] -> [test,spark] ?
(See also pyproject.toml below).
I think that will trigger the spark tests.
There was a problem hiding this comment.
Added, seems it works :)
However, should we also add "spark" to "numpy<2" test?
pip install ".[test,spark,test_numpy_pre2]"
There was a problem hiding this comment.
Good point. Yes, let's run them there as well.
(Happy to merge when that runs.)
* Add pandas optional dependency
| dependencies = [ | ||
| "numpy", | ||
| "tqdm", | ||
| "joblib>=0.14.0" |
There was a problem hiding this comment.
I see that joblib is no longer used. Can you remove it?
.github/workflows/test.yml
Outdated
| if [ "${{ matrix.numpy_version }}" = "numpy<2" ]; then | ||
| pip install ".[test,test_numpy_pre2]" | ||
| else | ||
| pip install ".[test]" |
There was a problem hiding this comment.
Good point. Yes, let's run them there as well.
(Happy to merge when that runs.)
